snuyanzin commented on code in PR #29697:
URL: https://github.com/apache/flink/pull/29697#discussion_r4473052782
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/keyselector/JoinKeyExtractor.java:
##########
@@ -83,6 +83,17 @@ public interface JoinKeyExtractor extends Serializable {
*/
int[] getJoinKeyIndices(int inputId);
+ /**
+ * Gets the field indices in the joined row of the previous inputs that
make up the key returned
+ * by {@link #getLeftSideJoinKey(int, RowData)} for a specific input depth.
+ *
+ * @param depth The current processing depth (0-based index), representing
the target input ID
+ * for state lookup.
Review Comment:
can you clarify what state lookup you mean here?
isn't the only caller `FlinkRelMdUpsertKeys` computing upsert-key metadata -
nothing to do with state lookup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
