[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858920#comment-15858920
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r100222823
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -112,6 +114,13 @@ public TaskManagerRunner(
// Initialize the TM metrics
TaskExecutorMetricsInitializer.instantiateStatusMetrics(taskManagerMetricGroup,
taskManagerServices.getNetworkEnvironment());
+ HeartbeatManagerImpl heartbeatManager = new
HeartbeatManagerImpl(
+
taskManagerConfiguration.getTimeout().toMilliseconds(),
+ resourceID,
+ executor,
+ Executors.newSingleThreadScheduledExecutor(),
--- End diff --
Yes, I totally agree with that and the advantages can avoid bringing extra
thread pool and run all the PRC messages in the uniform executor if
**RPCService** can handle well.
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
