[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856021#comment-15856021
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99825777
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
---
@@ -218,4 +218,12 @@ void failSlot(final ResourceID taskManagerId,
final TaskManagerLocation taskManagerLocation,
final UUID leaderId,
@RpcTimeout final Time timeout);
+
+ /**
+ * Send the heartbeat to job manager from task manager
+ *
+ * @param resourceID unique id of the task manager
+ * @param payload the payload information from the task manager
+ */
+ void heartbeatFromTaskManager(final ResourceID resourceID, final Object
payload);
--- End diff --
If it's `Void` at the moment, why not leaving this parameter out for the
moment?
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
