snuyanzin commented on code in PR #29825:
URL: https://github.com/apache/flink/pull/29825#discussion_r4514189043
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##########
@@ -1078,49 +1078,68 @@ object ScalarOperatorGens {
def generateIfElse(
ctx: CodeGeneratorContext,
operands: Seq[GeneratedExpression],
- resultType: LogicalType,
- i: Int = 0): GeneratedExpression = {
- // else part
- if (i == operands.size - 1) {
- generateCast(ctx, operands(i), resultType, nullOnFailure = true)
- } else {
- // check that the condition is boolean
- // we do not check for null instead we use the default value
- // thus null is false
- requireBoolean(operands(i))
- val condition = operands(i)
- val trueAction = generateCast(ctx, operands(i + 1), resultType,
nullOnFailure = true)
- val falseAction = generateIfElse(ctx, operands, resultType, i + 2)
+ resultType: LogicalType): GeneratedExpression = {
+ if (operands.size == 1) {
+ return generateCast(ctx, operands.head, resultType, nullOnFailure = true)
+ }
+ val Seq(resultTerm, nullTerm) = newNames(ctx, "result", "isNull")
+ val resultTypeTerm = primitiveTypeTermForType(resultType)
+ val defaultValue = primitiveDefaultValue(resultType)
- val Seq(resultTerm, nullTerm) = newNames(ctx, "result", "isNull")
- val resultTypeTerm = primitiveTypeTermForType(resultType)
- val defaultValue = primitiveDefaultValue(resultType)
+ def assign(action: GeneratedExpression): String =
+ s"""
+ |${action.code}
+ |$nullTerm = ${action.nullTerm};
+ |if (!$nullTerm) {
+ | $resultTerm = ${action.resultTerm};
+ |}
+ |""".stripMargin
- val operatorCode =
- s"""
- |${condition.code}
- |$resultTypeTerm $resultTerm = $defaultValue;
- |boolean $nullTerm;
- |if (${condition.resultTerm}) {
- | ${trueAction.code}
- | $nullTerm = ${trueAction.nullTerm};
- | if (!$nullTerm) {
- | $resultTerm = ${trueAction.resultTerm};
- | }
- |}
- |else {
- | ${falseAction.code}
- | $nullTerm = ${falseAction.nullTerm};
- | if (!$nullTerm) {
- | $resultTerm = ${falseAction.resultTerm};
- | }
- |}
- |""".stripMargin.trim
+ // a null condition is false via its default value
+ val whens = (0 until operands.size - 1 by 2).map {
Review Comment:
added a guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
