twalthr commented on code in PR #29825:
URL: https://github.com/apache/flink/pull/29825#discussion_r4514466244
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CaseFunctionsITCase.java:
##########
@@ -110,7 +212,19 @@ Stream<TestSetSpec> getTestSetSpecs() {
DataTypes.CHAR(1).notNull())
// operands that are never null
.testSqlResult("f5 = FALSE", true,
DataTypes.BOOLEAN().notNull())
- .testSqlResult("f1 + 1", 2, DataTypes.INT())
- .testSqlResult("f1 * 5", 5, DataTypes.INT()));
+ .testSqlResult("f1 + 1", 2, DataTypes.INT().notNull())
+ .testSqlResult("f1 * 5", 5, DataTypes.INT().notNull())
+ .testSqlResult("f1 < f2", false,
DataTypes.BOOLEAN().notNull()));
+ }
+
+ /** 250 WHENs; no ELSE if {@code elseValue} is null. */
+ private static String longCase(IntFunction<String> when, String elseValue)
{
+ return longCase(250, when, elseValue);
+ }
+
+ private static String longCase(int whens, IntFunction<String> when, String
elseValue) {
+ return "case "
Review Comment:
nit: upper case `CASE`, `END`, `ELSE` in the entire file, it is currently a
large mixture of different casing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
