arvindKandpal-ksolves opened a new pull request, #29919:
URL: https://github.com/apache/flink/pull/29919
## What is the purpose of the change
`FailureEnricherUtils#filterInvalidEnrichers` logs a warning when several
failure enrichers register the same output key. The message used `[%s]`, which
SLF4J does not replace, and the key was not passed as an argument. The warning
printed `[%s]` literally, so users could not see which output key was
duplicated.
## Brief change log
- Use `{}` for the key in the warning and pass `entry.getKey()` as an
argument
- Fix the duplicated word "have have" in the same message
- Assert the warning text in
`FailureEnricherUtilsTest#testValidatedEnrichersWithInvalidEntries` with
`LoggerAuditingExtension`
## Verifying this change
This change added tests and can be verified as follows:
- `FailureEnricherUtilsTest#testValidatedEnrichersWithInvalidEntries` now
checks that the warning contains the duplicate key (`[key2]`) and both enricher
class names. It fails without the fix (the logged message contains `[%s]`) and
passes with it.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]