snuyanzin commented on code in PR #29928:
URL: https://github.com/apache/flink/pull/29928#discussion_r4564528324
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/NullValueToProtoTest.java:
##########
@@ -213,4 +218,34 @@ void testNullStringLiteral() throws Exception {
NullTest nullTest = NullTest.parseFrom(bytes);
assertThat(nullTest.getStringMapMap().get("key")).isEqualTo("NULL");
}
+
+ private static Stream<Arguments> nullStringLiterals() {
+ return Stream.of(
+ Arguments.of("\"", "\""),
+ Arguments.of("'", "'"),
+ Arguments.of("`", "`"),
+ // a lone trailing backslash is dropped by unescaping
+ Arguments.of("\\", ""),
+ Arguments.of("\\\\", "\\"),
Review Comment:
keep it this way to avoid breaking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]