snuyanzin commented on code in PR #29928:
URL: https://github.com/apache/flink/pull/29928#discussion_r4564570861


##########
flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/util/PbCodegenUtils.java:
##########
@@ -184,7 +185,10 @@ public static String pbDefaultValueCode(
             case LONG:
                 return "0L";
             case STRING:
-                return "\"" + nullLiteral + "\"";
+                // unescape keeps old behavior: option \"NULL\" still writes 
"NULL"
+                return "\""
+                        + 
StringEscapeUtils.escapeJava(StringEscapeUtils.unescapeJava(nullLiteral))

Review Comment:
   keep it this way to avoid breaking changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to