Timm0 opened a new pull request, #29936:
URL: https://github.com/apache/flink/pull/29936

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA 
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are 
made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the 
pull request", where *FLINK-XXXX* should be replaced by the actual issue 
number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following 
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or 
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes. You can set up Azure Pipelines CI to do that following [this 
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message 
(including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   `Table#materializeInto` could only declare a materialized table's query and 
freshness. This adds `MaterializedTableDescriptor`, so a Table API program can 
also declare the other clauses of `CREATE OR ALTER MATERIALIZED TABLE`, like 
the schema (columns, watermark, primary key), distribution, partition keys, 
options, comment and refresh mode. The schema merge is shared with the SQL `AS 
<query>` statements, so both produce the same result.
   
   
   ## Brief change log
   
   - Add `@PublicEvolving` `MaterializedTableDescriptor` with its `Builder`, 
and `RefreshStrategy` (`automatic()`, `continuous()`, `full()`). _Note: Start 
mode follows in FLINK-41240._
   - Add `Table#materializeInto(String, MaterializedTableDescriptor)`. The 
`path` and `(path, Duration)` overloads now delegate to it, and freshness 
validation moves to the descriptor builder.
   - `QueryMaterializedTableMergeContext` is renamed to 
`DescriptorMaterializedTableMergeContext`, and merges a declared schema onto 
the stored query's schema. It rejects indexes, immutable columns, repeated 
columns, and persisted columns that the query doesn't produce.
   - CTAS, RTAS and SQL materialized tables now share the new 
`AsQuerySchemaMerger`, and the persisted-column check moves to 
`MaterializedTableSchemaUtils`. The existing SQL tests pass and there are no 
behavior changes.
   - Add `DescriptorMaterializedTableMergeContextTest`. 
`MaterializedTableTableApiITCase` now declares tables through the Table API, 
keeping one SQL test per statement category.
   - Document declaring and redeploying with a descriptor in `table-api.md`.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added `DescriptorMaterializedTableMergeContextTest`, which covers the 
schema merge:
       - Merging a declared computed column, watermark and primary key onto the 
query schema.
       - A declared column overriding a query column, with its type normalized 
to the default conversion class.
       - The query schema used as is when no schema is declared.
       - The rejections: a declared physical or persisted metadata column the 
query doesn't produce, an index, immutable columns, and a column declared twice.
     - `MaterializedTableTableApiITCase` now declares its materialized tables 
through the descriptor:
       - Partition keys, options, comment, freshness and `continuousRefresh()`.
       - A primary key with a hash distribution.
       - A primary key with an enforced changelog mode, followed by `ALTER ... 
AS`.
       - Two partition keys, refreshed with `REFRESH PARTITION`.
       - A redeploy without options or distribution, which resets the options 
and drops the distribution.
       - The setup also uses the Table API now. One SQL test each remains for 
`CREATE` and `CREATE OR ALTER`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs and JavaDocs
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change the checkbox below to `[X]` and replace the placeholder in the 
"Generated-by"
   line with the tool name and version. Otherwise remove the "Generated-by" 
line.
   See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this 
PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. 
See
   AGENTS.md for the full guidance.
   -->
   
   - [x] Yes (please specify the tool below)
   
   Generated-by: Claude Code Opus 5.5
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to