Timm0 commented on code in PR #29936:
URL: https://github.com/apache/flink/pull/29936#discussion_r4599078334


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/MaterializedPipeline.java:
##########
@@ -53,9 +53,13 @@ public interface MaterializedPipeline {
      * in full refresh mode is altered without changing its refresh workflow.
      *
      * <p>An existing materialized table keeps its freshness, comment and 
partition keys, so a
-     * freshness given to {@link Table#materializeInto(String, 
java.time.Duration)} is ignored. Its
-     * options are reset and its distribution is dropped, as by a {@code 
CREATE OR ALTER
-     * MATERIALIZED TABLE} without {@code WITH} and {@code DISTRIBUTED BY} 
clauses.
+     * declared one is ignored. A declared {@link 
RefreshStrategy#continuous()} or {@link

Review Comment:
   Done.



##########
docs/content/docs/sql/materialized-table/table-api.md:
##########
@@ -46,9 +46,37 @@ MaterializedTable revenue = tEnv.from("orders")
 The schema is derived from the stored SQL text of the query, and the path is 
resolved against the
 current catalog and database. The freshness is optional and defaults to
 [materialized-table.default-freshness.continuous]({{< ref 
"docs/dev/table/config" >}}#materialized-table-default-freshness-continuous).
-The refresh mode is derived from the freshness (see [Refresh Mode]({{< ref 
"docs/sql/materialized-table/overview" >}}#refresh-mode)).
+The refresh mode is derived from the freshness, unless a 
[`MaterializedTableDescriptor`](#declaring-a-materialized-table) declares it 
(see [Refresh Mode]({{< ref "docs/sql/materialized-table/overview" 
>}}#refresh-mode)).

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to