gustavodemorais opened a new pull request, #29937: URL: https://github.com/apache/flink/pull/29937
## What is the purpose of the change A streaming Top-N that outputs the row number emits its changelog per (partition key, row number), but the planner also exposed the input upsert key (e.g. id) as an upsert key of its output. Sinks and operators keyed by that input key then produced wrong results, e.g. deleted rows stayed in an upsert sink keyed by id. This PR stops exposing input upsert keys of such a Top-N, unless they are part of the partition key. ## Brief change log - Drop input upsert keys of a Top-N that outputs the row number in FlinkRelMdUpsertKeys, unless they are contained in the partition key - Keep all input upsert keys for window Top-N, which is insert-only - Update the nested Top-N plan and changelog expectations ## Verifying this change - FlinkRelMdUpsertKeysTest - TableSinkITCase - RankTest - RankITCase ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes (please specify the tool below) 2.1.304 (Claude Code) with Opus 5.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
