gustavodemorais commented on PR #29937:
URL: https://github.com/apache/flink/pull/29937#issuecomment-6921519984

   Synced with @fhueske on how to avoid this drifting in the future. The rank 
functions have two operation modes. The planner wasn't taking that into 
consideration when calculating the upsert keys. I created a small util function 
in the AbstractRankFunction. 
   
   Alternatives:
   - Create a runtime RankUtils and put it there (would be very short)
   - Generate the info during planning and pass it down to all operators (would 
have to change the signature of 6 operators/make the change bigger)
   
   Let me know what you think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to