jubins commented on PR #28473:
URL: https://github.com/apache/flink/pull/28473#issuecomment-6886154378
@snuyanzin, addressed all six comments in the latest push:
- Production line ('l' vs 'L'): kept the check as "l".equals(args[0]).
Rewriting 'l' to 'L' would change the meaning, since the parent maps 'l' to
int[] and 'L' to unsigned long. @vbhanuchander-lang showed the same on Sep 8. I
added a short comment in the code saying why the check has to stay on 'l'.
- Removed the long Javadoc on the first test.
- Removed the comment after the first value. It is now
values.add(Integer.MAX_VALUE + 10L).
- All test declarations now use List on the left side instead of ArrayList.
- Kept testNonLongTypecodesDelegateToSuper, trimmed down. It pins that other
typecodes still fall through to the parent, so a change to the condition cannot
silently swallow them. The comments inside it are gone.
@dianfu, the nits are addressed. Could you merge this when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]