pnowojski commented on code in PR #29942:
URL: https://github.com/apache/flink/pull/29942#discussion_r4583959674


##########
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/SubtaskGatewayImpl.java:
##########
@@ -133,12 +131,25 @@ public CompletableFuture<Acknowledge> 
sendEvent(OperatorEvent evt) {
         mainThreadExecutor.execute(
                 () -> {
                     sendEventInternal(sendAction, sendResult);
-                    
incompleteFuturesTracker.trackFutureWhileIncomplete(result);
+                    // A tolerated loss must not fail the checkpoints that 
wait for this event.
+                    incompleteFuturesTracker.trackFutureWhileIncomplete(
+                            result.handle(
+                                    (ack, failure) -> {
+                                        if (failure != null && 
!isToleratedLoss(evt, failure)) {
+                                            throw new 
CompletionException(failure);
+                                        }
+                                        return ack;

Review Comment:
   Shouldn't we log (`INFO`?) if a tolerated loss happened? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to