rionmonster commented on code in PR #29942:
URL: https://github.com/apache/flink/pull/29942#discussion_r4587600711


##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorSchedulerTest.java:
##########
@@ -446,6 +446,30 @@ void testConfirmCheckpointComplete() throws Exception {
                 .isEqualTo(checkpointId);
     }
 
+    @Test
+    void testCheckpointSucceedsIfTaskFinishesBeforeLossTolerantEventArrives() 
throws Exception {

Review Comment:
   Yes, the do cover _slightly_ different paths:
   - `OperatorCoordinatorHolderTest` exercises that the delivery will fail with 
the `TaskNoRunningException`, which covers the changes that we made within the 
`SubtaskGatewayImpl` area.
   - `OperatorCoordinatorSchedulerTest` tests the actual execution of an event 
in flight _when_ the task reaches a terminal state (triggering the failure of 
the pending futures), which covers the `ExecutionSubtaskAccess` changes.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to