Copilot commented on code in PR #179: URL: https://github.com/apache/flink-shaded/pull/179#discussion_r4584225703
########## flink-shaded-netty-4/src/main/resources/META-INF/NOTICE: ########## @@ -6,38 +6,38 @@ The Apache Software Foundation (http://www.apache.org/). This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) -- io.netty:netty-all:4.1.136.Final -- io.netty:netty-buffer:4.1.136.Final -- io.netty:netty-codec-dns:4.1.136.Final -- io.netty:netty-codec-haproxy:4.1.136.Final -- io.netty:netty-codec-http2:4.1.136.Final -- io.netty:netty-codec-http:4.1.136.Final -- io.netty:netty-codec-memcache:4.1.136.Final -- io.netty:netty-codec-mqtt:4.1.136.Final -- io.netty:netty-codec-redis:4.1.136.Final -- io.netty:netty-codec-smtp:4.1.136.Final -- io.netty:netty-codec-socks:4.1.136.Final -- io.netty:netty-codec-stomp:4.1.136.Final -- io.netty:netty-codec-xml:4.1.136.Final -- io.netty:netty-codec:4.1.136.Final -- io.netty:netty-common:4.1.136.Final -- io.netty:netty-handler-proxy:4.1.136.Final -- io.netty:netty-handler-ssl-ocsp:4.1.136.Final -- io.netty:netty-handler:4.1.136.Final -- io.netty:netty-resolver-dns-classes-macos:4.1.136.Final -- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.136.Final -- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.136.Final -- io.netty:netty-resolver-dns:4.1.136.Final -- io.netty:netty-resolver:4.1.136.Final -- io.netty:netty-transport-classes-epoll:4.1.136.Final -- io.netty:netty-transport-classes-kqueue:4.1.136.Final -- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.136.Final -- io.netty:netty-transport-native-epoll:linux-riscv64:4.1.136.Final -- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.136.Final -- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.136.Final -- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.136.Final -- io.netty:netty-transport-native-unix-common:4.1.136.Final -- io.netty:netty-transport-rxtx:4.1.136.Final -- io.netty:netty-transport-sctp:4.1.136.Final -- io.netty:netty-transport-udt:4.1.136.Final -- io.netty:netty-transport:4.1.136.Final \ No newline at end of file +- io.netty:netty-all:4.1.139.Final +- io.netty:netty-buffer:4.1.139.Final +- io.netty:netty-codec-dns:4.1.139.Final +- io.netty:netty-codec-haproxy:4.1.139.Final +- io.netty:netty-codec-http2:4.1.139.Final +- io.netty:netty-codec-http:4.1.139.Final +- io.netty:netty-codec-memcache:4.1.139.Final +- io.netty:netty-codec-mqtt:4.1.139.Final +- io.netty:netty-codec-redis:4.1.139.Final +- io.netty:netty-codec-smtp:4.1.139.Final +- io.netty:netty-codec-socks:4.1.139.Final +- io.netty:netty-codec-stomp:4.1.139.Final +- io.netty:netty-codec-xml:4.1.139.Final +- io.netty:netty-codec:4.1.139.Final +- io.netty:netty-common:4.1.139.Final +- io.netty:netty-handler-proxy:4.1.139.Final +- io.netty:netty-handler-ssl-ocsp:4.1.139.Final +- io.netty:netty-handler:4.1.139.Final +- io.netty:netty-resolver-dns-classes-macos:4.1.139.Final +- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.139.Final +- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.139.Final +- io.netty:netty-resolver-dns:4.1.139.Final +- io.netty:netty-resolver:4.1.139.Final +- io.netty:netty-transport-classes-epoll:4.1.139.Final +- io.netty:netty-transport-classes-kqueue:4.1.139.Final +- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.139.Final +- io.netty:netty-transport-native-epoll:linux-riscv64:4.1.139.Final +- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.139.Final +- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.139.Final +- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.139.Final +- io.netty:netty-transport-native-unix-common:4.1.139.Final +- io.netty:netty-transport-rxtx:4.1.139.Final +- io.netty:netty-transport-sctp:4.1.139.Final +- io.netty:netty-transport-udt:4.1.139.Final +- io.netty:netty-transport:4.1.139.Final Review Comment: The updated NOTICE entries changed formatting/indentation (previously these lines were indented). Since NOTICE files are legal/attribution artifacts, it’s best to avoid unrelated whitespace/structure churn and keep formatting consistent with the existing style. Consider restoring the prior indentation for the Netty entries (and apply the same approach across the other updated NOTICE files) while only changing version strings. ########## flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/src/main/resources/META-INF/NOTICE: ########## @@ -9,15 +9,15 @@ This project bundles the following dependencies under the Apache Software Licens - com.google.guava:guava:33.4.0-jre - commons-io:commons-io:2.11.0 - io.dropwizard.metrics:metrics-core:4.1.12.1 -- io.netty:netty-buffer:4.1.136.Final -- io.netty:netty-codec:4.1.136.Final -- io.netty:netty-common:4.1.136.Final -- io.netty:netty-handler:4.1.136.Final -- io.netty:netty-resolver:4.1.136.Final -- io.netty:netty-transport-classes-epoll:4.1.136.Final -- io.netty:netty-transport-native-epoll:4.1.136.Final -- io.netty:netty-transport-native-unix-common:4.1.136.Final -- io.netty:netty-transport:4.1.136.Final +- io.netty:netty-buffer:4.1.139.Final +- io.netty:netty-codec:4.1.139.Final +- io.netty:netty-common:4.1.139.Final +- io.netty:netty-handler:4.1.139.Final +- io.netty:netty-resolver:4.1.139.Final +- io.netty:netty-transport-classes-epoll:4.1.139.Final +- io.netty:netty-transport-native-epoll:4.1.139.Final +- io.netty:netty-transport-native-unix-common:4.1.139.Final +- io.netty:netty-transport:4.1.139.Final Review Comment: These Netty lines were previously indented (nested) relative to surrounding entries, but are now rendered at the top level. Even if tooling accepts it, this makes the NOTICE dependency tree harder to read and introduces non-version-related churn. Recommend preserving the original indentation/nesting and only updating the version number (same issue appears in the other `flink-shaded-zookeeper-*` NOTICE updates). ########## flink-shaded-swagger/src/main/resources/META-INF/NOTICE: ########## @@ -6,8 +6,8 @@ The Apache Software Foundation (http://www.apache.org/). This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) -- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.18.10 -- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.10 +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.18.12 +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.12 Review Comment: The Jackson NOTICE entries appear to have had their indentation reduced/removed compared to the prior format. To keep NOTICE diffs minimal and consistent, consider restoring the previous indentation style here (and similarly in the shaded Jackson NOTICE files) while only changing the version numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
