spuru9 commented on code in PR #179:
URL: https://github.com/apache/flink-shaded/pull/179#discussion_r4585176144


##########
flink-shaded-netty-4/src/main/resources/META-INF/NOTICE:
##########
@@ -6,38 +6,38 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- io.netty:netty-all:4.1.136.Final
-- io.netty:netty-buffer:4.1.136.Final
-- io.netty:netty-codec-dns:4.1.136.Final
-- io.netty:netty-codec-haproxy:4.1.136.Final
-- io.netty:netty-codec-http2:4.1.136.Final
-- io.netty:netty-codec-http:4.1.136.Final
-- io.netty:netty-codec-memcache:4.1.136.Final
-- io.netty:netty-codec-mqtt:4.1.136.Final
-- io.netty:netty-codec-redis:4.1.136.Final
-- io.netty:netty-codec-smtp:4.1.136.Final
-- io.netty:netty-codec-socks:4.1.136.Final
-- io.netty:netty-codec-stomp:4.1.136.Final
-- io.netty:netty-codec-xml:4.1.136.Final
-- io.netty:netty-codec:4.1.136.Final
-- io.netty:netty-common:4.1.136.Final
-- io.netty:netty-handler-proxy:4.1.136.Final
-- io.netty:netty-handler-ssl-ocsp:4.1.136.Final
-- io.netty:netty-handler:4.1.136.Final
-- io.netty:netty-resolver-dns-classes-macos:4.1.136.Final
-- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.136.Final
-- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.136.Final
-- io.netty:netty-resolver-dns:4.1.136.Final
-- io.netty:netty-resolver:4.1.136.Final
-- io.netty:netty-transport-classes-epoll:4.1.136.Final
-- io.netty:netty-transport-classes-kqueue:4.1.136.Final
-- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.136.Final
-- io.netty:netty-transport-native-epoll:linux-riscv64:4.1.136.Final
-- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.136.Final
-- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.136.Final
-- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.136.Final
-- io.netty:netty-transport-native-unix-common:4.1.136.Final
-- io.netty:netty-transport-rxtx:4.1.136.Final
-- io.netty:netty-transport-sctp:4.1.136.Final
-- io.netty:netty-transport-udt:4.1.136.Final
-- io.netty:netty-transport:4.1.136.Final
\ No newline at end of file
+- io.netty:netty-all:4.1.139.Final
+- io.netty:netty-buffer:4.1.139.Final
+- io.netty:netty-codec-dns:4.1.139.Final
+- io.netty:netty-codec-haproxy:4.1.139.Final
+- io.netty:netty-codec-http2:4.1.139.Final
+- io.netty:netty-codec-http:4.1.139.Final
+- io.netty:netty-codec-memcache:4.1.139.Final
+- io.netty:netty-codec-mqtt:4.1.139.Final
+- io.netty:netty-codec-redis:4.1.139.Final
+- io.netty:netty-codec-smtp:4.1.139.Final
+- io.netty:netty-codec-socks:4.1.139.Final
+- io.netty:netty-codec-stomp:4.1.139.Final
+- io.netty:netty-codec-xml:4.1.139.Final
+- io.netty:netty-codec:4.1.139.Final
+- io.netty:netty-common:4.1.139.Final
+- io.netty:netty-handler-proxy:4.1.139.Final
+- io.netty:netty-handler-ssl-ocsp:4.1.139.Final
+- io.netty:netty-handler:4.1.139.Final
+- io.netty:netty-resolver-dns-classes-macos:4.1.139.Final
+- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.139.Final
+- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.139.Final
+- io.netty:netty-resolver-dns:4.1.139.Final
+- io.netty:netty-resolver:4.1.139.Final
+- io.netty:netty-transport-classes-epoll:4.1.139.Final
+- io.netty:netty-transport-classes-kqueue:4.1.139.Final
+- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.139.Final
+- io.netty:netty-transport-native-epoll:linux-riscv64:4.1.139.Final
+- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.139.Final
+- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.139.Final
+- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.139.Final
+- io.netty:netty-transport-native-unix-common:4.1.139.Final
+- io.netty:netty-transport-rxtx:4.1.139.Final
+- io.netty:netty-transport-sctp:4.1.139.Final
+- io.netty:netty-transport-udt:4.1.139.Final
+- io.netty:netty-transport:4.1.139.Final

Review Comment:
   The indentation hasn't changed. In the diff, `-- io.netty:…` and `+- 
io.netty:…` are the diff marker followed by the NOTICE list bullet `- `. No 
line in this file starts with whitespace, before or after the change, and `git 
diff -w` reports the same changes as `git diff`. Apart from `4.1.136.Final` → 
`4.1.139.Final`, the file is byte-for-byte identical to `release-20.0`, 
including the missing newline at the end of the file.
   



##########
flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/src/main/resources/META-INF/NOTICE:
##########
@@ -9,15 +9,15 @@ This project bundles the following dependencies under the 
Apache Software Licens
 - com.google.guava:guava:33.4.0-jre
 - commons-io:commons-io:2.11.0
 - io.dropwizard.metrics:metrics-core:4.1.12.1
-- io.netty:netty-buffer:4.1.136.Final
-- io.netty:netty-codec:4.1.136.Final
-- io.netty:netty-common:4.1.136.Final
-- io.netty:netty-handler:4.1.136.Final
-- io.netty:netty-resolver:4.1.136.Final
-- io.netty:netty-transport-classes-epoll:4.1.136.Final
-- io.netty:netty-transport-native-epoll:4.1.136.Final
-- io.netty:netty-transport-native-unix-common:4.1.136.Final
-- io.netty:netty-transport:4.1.136.Final
+- io.netty:netty-buffer:4.1.139.Final
+- io.netty:netty-codec:4.1.139.Final
+- io.netty:netty-common:4.1.139.Final
+- io.netty:netty-handler:4.1.139.Final
+- io.netty:netty-resolver:4.1.139.Final
+- io.netty:netty-transport-classes-epoll:4.1.139.Final
+- io.netty:netty-transport-native-epoll:4.1.139.Final
+- io.netty:netty-transport-native-unix-common:4.1.139.Final
+- io.netty:netty-transport:4.1.139.Final

Review Comment:
   There's no nesting to keep. On `release-20.0`, these `io.netty:*` entries 
sit at the top level, like the other entries in the list (`- 
com.google.guava:…`, `- io.dropwizard.metrics:…`). The leading `-`/`+` in the 
diff is the diff marker. All four `flink-shaded-zookeeper-3*` NOTICE files 
differ from `release-20.0` only in `4.1.136.Final` → `4.1.139.Final`, and `git 
diff -w` reports the same changes as `git diff`.
   



##########
flink-shaded-swagger/src/main/resources/META-INF/NOTICE:
##########
@@ -6,8 +6,8 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.18.10
-- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.10
+- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.18.12
+- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.12

Review Comment:
   The indentation hasn't changed. The leading `-`/`+` is the diff marker, and 
the `- ` after it is the NOTICE list bullet, as on `release-20.0`. This NOTICE 
and the `flink-shaded-jackson-2` and `flink-shaded-jackson-module-jsonSchema-2` 
NOTICEs differ from `release-20.0` only in `2.18.10` → `2.18.12`, and no line 
in them starts with whitespace.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to