snuyanzin commented on code in PR #29987:
URL: https://github.com/apache/flink/pull/29987#discussion_r4599308685


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java:
##########
@@ -219,14 +219,35 @@ protected abstract Transformation<T> 
translateToPlanInternal(
             PlannerBase planner, ExecNodeConfig config);
 
     private boolean inputsContainSingleton(Transformation<T> transformation) {
-        return inputsContainSingleton()
-                || transformation.getInputs().stream()
-                        .anyMatch(
-                                input ->
-                                        input instanceof 
PartitionTransformation
-                                                && 
((PartitionTransformation<?>) input)
-                                                                
.getPartitioner()
-                                                        instanceof 
GlobalPartitioner);
+        return inputsContainSingleton() || 
hasSingletonExchangeInput(transformation);
+    }
+
+    /**
+     * Whether an input of the given transformation is a singleton exchange, 
although the {@link
+     * InputProperty}s of this node don't declare a SINGLETON distribution.
+     *
+     * <p>Since FLINK-41440 (Flink 2.4), physical nodes whose rule requests an 
input distribution

Review Comment:
   do we need version here?
   master is already on 2.5 btw



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to