twalthr commented on code in PR #29987:
URL: https://github.com/apache/flink/pull/29987#discussion_r4600552050


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalLookupJoin.scala:
##########
@@ -155,6 +156,16 @@ abstract class CommonPhysicalLookupJoin(
       Collections.emptyList[RelDataTypeField])
   }
 
+  /** Only the hash shuffle of the LOOKUP hint requests a distribution of the 
input. */
+  protected def deriveInputProperty(): InputProperty = {

Review Comment:
   Done, deriveInputProperty now also requires non-empty join key pairs, 
computed the same way as in CommonLookupJoinRule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to