[ 
https://issues.apache.org/jira/browse/FLINK-41078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser resolved FLINK-41078.
------------------------------------
    Fix Version/s: 2.2.2
                   1.20.6
                   2.3.1
                   2.4.0
       Resolution: Fixed

Fixed in apache/flink

master: 9c9ab85360d73cfe6e4942f3e575e98163dddea5
release-2.4: 5719f43bae35dca11bc6e72787c259c523d838d6
release-2.3: 47bb57b3fed85a81fe639f09585e056956c3bdb8
release-2.2: 6bc5ce916bfe73714c9faa088259d04dd3c42647
release-1.20: 41be103b48e0874410c79fec822cbca5af361c9c

> FineGrainedSlotManager stops scheduling delayed checks after one of them threw
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-41078
>                 URL: https://issues.apache.org/jira/browse/FLINK-41078
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 2.3.0, 2.2.2, 1.20.6, 2.4.0
>            Reporter: Martijn Visser
>            Assignee: Martijn Visser
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.2.2, 1.20.6, 2.3.1, 2.4.0
>
>
> {{FineGrainedSlotManager#checkResourceRequirementsWithDelay}} and 
> {{#declareNeededResourcesWithDelay}} debounce on a {{CompletableFuture}} that 
> is completed after the delayed body ran, not in a finally. If 
> {{checkResourceRequirements()}} or {{declareNeededResources()}} throws, the 
> future stays incomplete, {{isDone()}} is false for the rest of the 
> ResourceManager's life, and no delayed check is ever scheduled again: 
> requirement changes, task manager registrations, slot reports and freed slots 
> stop triggering allocation, and in the active ResourceManager no resource 
> declaration reaches the driver any more. The exception itself is logged once 
> by the RPC actor and then everything is silent. Both delays default to 50 ms, 
> so production runs on this path. The fix is to complete the future in a 
> finally; the handling of the exception itself is FLINK-34589.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to