[ 
https://issues.apache.org/jira/browse/FLINK-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865638#comment-15865638
 ] 

ASF GitHub Bot commented on FLINK-5219:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3266#discussion_r101014280
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala
 ---
    @@ -141,16 +141,18 @@ class DataSetWindowAggregateITCase(configMode: 
TableConfigMode)
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    -  @Test(expected = classOf[UnsupportedOperationException])
    +  @Test
       def testAlldEventTimeSessionGroupWindow(): Unit = {
    -    // Non-grouping Session window on event-time are currently not 
supported
         val env = ExecutionEnvironment.getExecutionEnvironment
         val tEnv = TableEnvironment.getTableEnvironment(env, config)
         val table = env.fromCollection(data).toTable(tEnv, 'long, 'int, 
'string)
         val windowedTable =table
           .window(Session withGap 7.milli on 'long as 'w)
           .groupBy('w)
    -      .select('string.count).toDataSet[Row].collect()
    +      .select('string.count)
    +    val results = windowedTable.toDataSet[Row].collect()
    +    val expected = "6\n1"
    --- End diff --
    
    Would be good to change the query in a way that it checks that multiple 
sessions are correctly computed.


> Add non-grouped session windows for batch tables
> ------------------------------------------------
>
>                 Key: FLINK-5219
>                 URL: https://issues.apache.org/jira/browse/FLINK-5219
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Add non-grouped session windows for batch tables as described in 
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to