[
https://issues.apache.org/jira/browse/FLINK-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874270#comment-15874270
]
ASF GitHub Bot commented on FLINK-5414:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3338#discussion_r101977305
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -108,62 +109,73 @@ object ProjectionTranslator {
tableEnv: TableEnvironment,
aggNames: Map[Expression, String],
propNames: Map[Expression, String]): Seq[NamedExpression] = {
- exprs.map(replaceAggregationsAndProperties(_, tableEnv, aggNames,
propNames))
- .map(UnresolvedAlias)
- }
- private def replaceAggregationsAndProperties(
+ val projectNames: mutable.HashSet[String] = new mutable.HashSet[String]
+
+ def replaceAggregationsAndProperties(
--- End diff --
Can you rename this or the outer function? Having two functions with the
same names is confusing.
> Bump up Calcite version to 1.11
> -------------------------------
>
> Key: FLINK-5414
> URL: https://issues.apache.org/jira/browse/FLINK-5414
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> The upcoming Calcite release 1.11 has a lot of stability fixes and new
> features. We should update it for the Table API.
> E.g. we can hopefully merge FLINK-4864
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
