[ 
https://issues.apache.org/jira/browse/FLINK-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874683#comment-15874683
 ] 

ASF GitHub Bot commented on FLINK-5414:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3338#discussion_r102040448
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
 ---
    @@ -155,15 +155,15 @@ class ExpressionReductionTest extends TableTestBase {
           "DataSetCalc",
           batchTableNode(0),
           term("select",
    -        "13 AS _c0",
    +        "CAST(13) AS _c0",
    --- End diff --
    
    Yes, because I changed the default nullable to `true`, but the reduced 
constant is `NOT NULL`, so a `CAST` is here. Do you have any ideas to fix this? 
    
    The default nullable changed to `true` is because 
`UserDefinedScalarFunctionTest.testResults` and 
`ArrayTypeTest.testArrayLiterals` fail.


> Bump up Calcite version to 1.11
> -------------------------------
>
>                 Key: FLINK-5414
>                 URL: https://issues.apache.org/jira/browse/FLINK-5414
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Jark Wu
>
> The upcoming Calcite release 1.11 has a lot of stability fixes and new 
> features. We should update it for the Table API.
> E.g. we can hopefully merge FLINK-4864



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to