[
https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874368#comment-15874368
]
ASF GitHub Bot commented on FLINK-5090:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101992784
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -385,6 +388,20 @@ public Task(
++counter;
}
+ // register detailed network metrics, if configured
+ if
(tmConfig.getBoolean(ConfigConstants.NETWORK_DETAILED_METRICS_KEY, false)) {
+ // output metrics
--- End diff --
Regarding the MetricGroup struccture/naming i would suggest the following:
```
MetricGroup networkGroup = metricGroup.addGroup("Network"); // this is for
consistency purposes
MetricGroup inputGroup = networkGroup.addGroup("Input"); // this is optional
MetricGroup outputGroup = networkGroup.addGroup("Output"); // this is
optional
for (...) {
X.registerQueueLengthMetrics(metricGroup.addGroup(i), <gate/partition>);
}
```
> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
> Key: FLINK-5090
> URL: https://issues.apache.org/jira/browse/FLINK-5090
> Project: Flink
> Issue Type: New Feature
> Components: Network
> Affects Versions: 1.1.3
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed
> metrics about the length of network input and output queues.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
