[ 
https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875993#comment-15875993
 ] 

ASF GitHub Bot commented on FLINK-5090:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r102210056
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
    @@ -227,6 +227,14 @@
        public static final String TASK_MANAGER_NETWORK_NUM_BUFFERS_KEY = 
"taskmanager.network.numberOfBuffers";
     
        /**
    +    * Boolean flag to enable/disable more detailed metrics about 
inbound/outbound network queue lengths
    +    */
    +   @PublicEvolving
    +   public static final ConfigOption<Boolean> NETWORK_DETAILED_METRICS_KEY =
    --- End diff --
    
    I don't think ConfigOptions are supposed to be in this class; itshould be 
moved to either ```NetworkOptions``` or ```MetricOptions```.


> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
>                 Key: FLINK-5090
>                 URL: https://issues.apache.org/jira/browse/FLINK-5090
>             Project: Flink
>          Issue Type: New Feature
>          Components: Network
>    Affects Versions: 1.1.3
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed 
> metrics about the length of network input and output queues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to