[
https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875342#comment-15875342
]
ASF GitHub Bot commented on FLINK-4856:
---------------------------------------
Github user shixiaogang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3336#discussion_r102129362
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -834,7 +836,7 @@ private void restoreKVStateData() throws IOException,
RocksDBException {
}
@Override
- protected <N, T> InternalValueState<N, T> createValueState(
+ public <N, T> InternalValueState<N, T> createValueState(
--- End diff --
It is mainly due to the unit tests in `KvStateRequestSerializerTest` which
need the accessors to `InternalKvState`. A better choice to use
`getPartitionState()` to obtain a user-facing state and convert it to an
internal state. What do you think?
> Add MapState for keyed streams
> ------------------------------
>
> Key: FLINK-4856
> URL: https://issues.apache.org/jira/browse/FLINK-4856
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API, State Backends, Checkpointing
> Reporter: Xiaogang Shi
> Assignee: Xiaogang Shi
>
> Many states in keyed streams are organized as key-value pairs. Currently,
> these states are implemented by storing the entire map into a ValueState or a
> ListState. The implementation however is very costly because all entries have
> to be serialized/deserialized when updating a single entry. To improve the
> efficiency of these states, MapStates are urgently needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
