[
https://issues.apache.org/jira/browse/FLINK-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875513#comment-15875513
]
ASF GitHub Bot commented on FLINK-5692:
---------------------------------------
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3373
[FLINK-5692] [config] Add an Option to Deactivate Kryo Fallback for
Serializers
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmingjian/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3373
----
commit 1ff46e53efa2094ac6881b1ca014bf7752277ff2
Author: Jin Mingjian <[email protected]>
Date: 2017-02-21T03:57:21Z
[FLINK-5692] [config] Add an Option to Deactivate Kryo Fallback for
Serializers
----
> Add an Option to Deactivate Kryo Fallback for Serializers
> ---------------------------------------------------------
>
> Key: FLINK-5692
> URL: https://issues.apache.org/jira/browse/FLINK-5692
> Project: Flink
> Issue Type: New Feature
> Components: Type Serialization System
> Affects Versions: 1.2.0
> Reporter: Stephan Ewen
> Assignee: Jin Mingjian
> Labels: easyfix, starter
>
> Some users want to avoid that Flink's serializers use Kryo, as it can easily
> become a hotspot in serialization.
> For those users, it would help if there is a flag to "deactive generic
> types". Those users could then see where types are used that default to Kryo
> and change these types (make them PoJos, Value types, or write custom
> serializers).
> There are two ways to approach that:
> 1. (Simple) Make {{GenericTypeInfo}} threw an exception whenever it would
> create a Kryo Serializer (when the respective flag is set in the
> {{ExecutionConfig}})
> 2. Have a static flag on the {{TypeExtractor}} to throw an exception
> whenever it would create a {{GenericTypeInfo}}. This approach has the
> downside of introducing some static configuration to the TypeExtractor, but
> may be more helpful because it throws exceptions in the programs at points
> where the types are used (not where the serializers are created, which may be
> much later).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
