[
https://issues.apache.org/jira/browse/FLINK-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877970#comment-15877970
]
ASF GitHub Bot commented on FLINK-5692:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3373#discussion_r102429969
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java
---
@@ -64,4 +68,15 @@ public void testConfigurationOfParallelism() {
assertEquals(parallelism, config.getParallelism());
}
+ @Test(expected = UnsupportedOperationException.class)
--- End diff --
I think this test would also pass of line 75 already throws the exception.
I personally discourage the `@Test(expected = )` pattern completely, as you
have no check which statement actually throws the exception.
> Add an Option to Deactivate Kryo Fallback for Serializers
> ---------------------------------------------------------
>
> Key: FLINK-5692
> URL: https://issues.apache.org/jira/browse/FLINK-5692
> Project: Flink
> Issue Type: New Feature
> Components: Type Serialization System
> Affects Versions: 1.2.0
> Reporter: Stephan Ewen
> Assignee: Jin Mingjian
> Labels: easyfix, starter
>
> Some users want to avoid that Flink's serializers use Kryo, as it can easily
> become a hotspot in serialization.
> For those users, it would help if there is a flag to "deactive generic
> types". Those users could then see where types are used that default to Kryo
> and change these types (make them PoJos, Value types, or write custom
> serializers).
> There are two ways to approach that:
> 1. (Simple) Make {{GenericTypeInfo}} threw an exception whenever it would
> create a Kryo Serializer (when the respective flag is set in the
> {{ExecutionConfig}})
> 2. Have a static flag on the {{TypeExtractor}} to throw an exception
> whenever it would create a {{GenericTypeInfo}}. This approach has the
> downside of introducing some static configuration to the TypeExtractor, but
> may be more helpful because it throws exceptions in the programs at points
> where the types are used (not where the serializers are created, which may be
> much later).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
