Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102204839
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
---
@@ -165,20 +286,36 @@ public void beforeBulk(long executionId, BulkRequest
request) { }
@Override
public void afterBulk(long executionId,
BulkRequest request, BulkResponse response) {
if (response.hasFailures()) {
- for (BulkItemResponse itemResp
: response.getItems()) {
- Throwable failure =
callBridge.extractFailureCauseFromBulkItemResponse(itemResp);
+ BulkItemResponse itemResponse;
+ Throwable failure;
+
+ for (int i = 0; i <
response.getItems().length; i++) {
+ itemResponse =
response.getItems()[i];
+ failure =
callBridge.extractFailureCauseFromBulkItemResponse(itemResponse);
if (failure != null) {
-
LOG.error("Failed Elasticsearch item request: {}", failure.getMessage(),
failure);
-
failureThrowable.compareAndSet(null, failure);
+
LOG.error("Failed Elasticsearch item request: {}",
itemResponse.getFailureMessage(), failure);
+
+ if
(failureHandler.onFailure(request.requests().get(i), failure, requestIndexer)) {
+
failureThrowable.compareAndSet(null, failure);
+ }
}
}
}
+
+
numPendingRequests.getAndAdd(-request.numberOfActions());
}
@Override
public void afterBulk(long executionId,
BulkRequest request, Throwable failure) {
- LOG.error("Failed Elasticsearch bulk
request: {}", failure.getMessage(), failure);
- failureThrowable.compareAndSet(null,
failure);
+ LOG.error("Failed Elasticsearch bulk
request: {}", failure.getMessage(), failure.getCause());
+
+ // whole bulk request failures are
usually just temporary timeouts on
+ // the Elasticsearch side; simply retry
all action requests in the bulk
+ for (ActionRequest action :
request.requests()) {
+ requestIndexer.add(action);
+ }
--- End diff --
Thank you. I'm undecided if we want to add this here or not.
Just based on my experience with the Kafka connector, at some point there
is a user who wants to have a very specific custom behavior :) But we can also
keep it as is and fix it if a user needs it (worst case: they have to override
our implementation)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
