Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3358
@rmetzger All of your comments have been addressed, and tests for the new
features have been added (in `ElasticsearchSinkBaseTest`). Can you take another
look? Thanks a lot!
Some notes on changes I made that weren't previously discussed:
1. Renamed `NoOpActionRequestFailureHandler` to just
`NoOpActionFailureHandler` - less of a mouthful ;-)
2. I added the responsed REST status code through the failure handler's
`onFailure(...)` callback. The reason for this is explained in the doc /
Javadoc changes of the last follow-up commit (c594523).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
