[ 
https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876695#comment-15876695
 ] 

Dawid Wysakowicz commented on FLINK-5824:
-----------------------------------------

I've fixed all direct String <> bytes conversions as listed by Findbugs.

Still Findbugs shows
34 reliance on default encoding  in mainbase
144 in mainbase + tests

Those reliances are while using different kinds of Output/InputStreams mainly 
with FileOutputStream

Do we also want to use UTF_8 in those cases?

Current version one can check at https://github.com/dawidwys/flink/tree/encoding


> Fix String/byte conversions without explicit encoding
> -----------------------------------------------------
>
>                 Key: FLINK-5824
>                 URL: https://issues.apache.org/jira/browse/FLINK-5824
>             Project: Flink
>          Issue Type: Bug
>          Components: Python API, Queryable State, State Backends, 
> Checkpointing, Webfrontend
>            Reporter: Ufuk Celebi
>            Assignee: Dawid Wysakowicz
>            Priority: Blocker
>
> In a couple of places we convert Strings to bytes and bytes back to Strings 
> without explicitly specifying an encoding. This can lead to problems when 
> client and server default encodings differ.
> The task of this JIRA is to go over the whole project and look for 
> conversions where we don't specify an encoding and fix it to specify UTF-8 
> explicitly.
> For starters, we can {{grep -R 'getBytes()' .}}, which already reveals many 
> problematic places.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to