[
https://issues.apache.org/jira/browse/FLINK-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878264#comment-15878264
]
ASF GitHub Bot commented on FLINK-5645:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3377#discussion_r102467283
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -855,14 +877,23 @@ private boolean processFail(Throwable t, boolean
isCallback) {
}
if (current == CANCELING) {
- cancelingComplete();
+ cancelingComplete(userAccumulators, metrics);
return false;
}
if (transitionState(current, FAILED, t)) {
// success (in a manner of speaking)
this.failureCause = t;
+ if (userAccumulators != null) {
+ synchronized (accumulatorLock) {
+ this.userAccumulators =
userAccumulators;
+ }
+ }
+ if (metrics != null) {
+ this.ioMetrics = metrics;
+ }
--- End diff --
Can this also be a separate method?
> IOMetrics transfer through ExecGraph does not work for failed jobs
> ------------------------------------------------------------------
>
> Key: FLINK-5645
> URL: https://issues.apache.org/jira/browse/FLINK-5645
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Webfrontend
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
>
> While a job is running the web-interface polls IO metrics using the
> MetricFetcher/MetricQueryService. For finished jobs these metrics are stored
> in the ExecutionGraph; each vertex has an IOMetrics object; basically a
> snapshot taken when the task was finished.
> For completed jobs this mechanism is working. However, for failed jobs it
> doesn't; in this case last fetched metrics are displayed.
> This isn't intended behavior and should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
