Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r102745192
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -198,9 +197,9 @@ public static TaskManagerServices fromConfiguration(
final FileCache fileCache = new
FileCache(taskManagerServicesConfiguration.getTmpDirPaths());
- final List<ResourceProfile> resourceProfiles = new
ArrayList<>(taskManagerServicesConfiguration.getNumberOfSlots());
+ final List<ResourceProfile> resourceProfiles =
taskManagerServicesConfiguration.getResourceProfiles();
- for (int i = 0; i <
taskManagerServicesConfiguration.getNumberOfSlots(); i++) {
+ for (int i = resourceProfiles.size(); i <
taskManagerServicesConfiguration.getNumberOfSlots(); i++) {
resourceProfiles.add(new ResourceProfile(1.0, 42L));
--- End diff --
I think we should make sure that Flink still works also if you don't have a
resource profile specified. Maybe introducing a resource profile which matches
all other resource profiles or by trying to derive it somehow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
