Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r102682612
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
---
@@ -353,5 +376,16 @@ private static void checkConfigParameter(boolean
condition, Object parameter, St
name + " : " + parameter + " - " +
errorMessage);
}
}
+
+ private void addResourceProfile(ResourceProfile resourceProfile) {
+ this.resourceProfiles.add(resourceProfile);
+ }
--- End diff --
imo the configuration object should be immutable. That way one cannot
introduce side effects after the object has been created.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
