[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880751#comment-15880751
]
ASF GitHub Bot commented on FLINK-5791:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r102679342
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -323,7 +326,8 @@ private void requestYarnContainer(Resource resource,
Priority priority) {
numPendingContainerRequests);
}
- private ContainerLaunchContext createTaskExecutorLaunchContext(Resource
resource, String containerId, String host)
+ private ContainerLaunchContext createTaskExecutorLaunchContext(Resource
resource,
+ String containerId, String host, Priority priority)
--- End diff --
If breaking parameter lists, then every parameter should be in a separate
line
> Resource should be strictly matched when allocating for yarn
> ------------------------------------------------------------
>
> Key: FLINK-5791
> URL: https://issues.apache.org/jira/browse/FLINK-5791
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> In flip6, for yarn mode, resource should be assigned as requested to avoid
> resource wasting and OOM.
> 1. YarnResourceManager will request container according to ResourceProfile
> in slot request form JM.
> 2. RM will pass the ResourceProfile to TM for initializing its slots.
> 3. RM should match the slots offered by TM with SlotRequest from JM strictly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
