Github user shuai-xu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3304#discussion_r102909687
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -245,7 +248,7 @@ public void onContainersAllocated(List<Container> 
containers) {
                        try {
                                /** Context information used to start a 
TaskExecutor Java process */
                                ContainerLaunchContext 
taskExecutorLaunchContext =
    -                                           
createTaskExecutorLaunchContext(container.getResource(), 
container.getId().toString(), container.getNodeId().getHost());
    +                                           
createTaskExecutorLaunchContext(container.getResource(), 
container.getId().toString(), container.getNodeId().getHost(), 
container.getPriority());
    --- End diff --
    
    Yes, this is a problem. But if we use the resource profile retrieved from 
container, it may be different from the original request, they can not be 
matched. And only when the resource requested is too small, yarn will return a 
container bigger   than requested to avoid resource fragmentation, or else it 
will return what we requested. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to