Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r102945035
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
 ---
    @@ -105,6 +110,105 @@
        @Rule
        public TestName name = new TestName();
     
    +   @Test
    +   public void testHeartbeatTimeoutWithJobManager() throws Exception {
    +           final JobID jobId = new JobID();
    +           final Configuration configuration = new Configuration();
    +           final TaskManagerConfiguration tmConfig = 
TaskManagerConfiguration.fromConfiguration(configuration);
    +           final ResourceID tmResourceId = new ResourceID("tm");
    +           final TaskManagerLocation taskManagerLocation = new 
TaskManagerLocation(tmResourceId, InetAddress.getLoopbackAddress(), 1234);
    +           final TaskSlotTable taskSlotTable = new 
TaskSlotTable(Arrays.asList(mock(ResourceProfile.class)), 
mock(TimerService.class));
    +
    +           final TestingSerialRpcService rpc = new 
TestingSerialRpcService();
    +           final JobLeaderService jobLeaderService = new 
JobLeaderService(taskManagerLocation);
    +           final TestingHighAvailabilityServices haServices = new 
TestingHighAvailabilityServices();
    +           final TestingLeaderRetrievalService rmLeaderRetrievalService = 
new TestingLeaderRetrievalService();
    +           final TestingLeaderRetrievalService jmLeaderRetrievalService = 
new TestingLeaderRetrievalService();
    +           haServices.setJobMasterLeaderRetriever(jobId, 
jmLeaderRetrievalService);
    +           
haServices.setResourceManagerLeaderRetriever(rmLeaderRetrievalService);
    +
    +           final TestingFatalErrorHandler testingFatalErrorHandler = new 
TestingFatalErrorHandler();
    +
    +           final long heartbeatTimeout = 1000L;
    --- End diff --
    
    I think we should lower the timeout for the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to