Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r102759091
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -732,7 +765,21 @@ public RegistrationResponse apply(TaskExecutorGateway
taskExecutorGateway, Throw
slotPoolGateway.registerTaskManager(taskManagerId);
registeredTaskManagers.put(taskManagerId, Tuple2.of(taskManagerLocation,
taskExecutorGateway));
- return new
JMTMRegistrationSuccess(taskManagerId, libraryCacheManager.getBlobServerPort());
+
+ // monitor the task manager as
heartbeat target
+
heartbeatManager.monitorTarget(taskManagerId, new HeartbeatTarget<Void>() {
+ @Override
+ public void
sendHeartbeat(ResourceID resourceID, Void payload) {
+ // the task manager
will not request heartbeat, so this method will never be called currently
+ }
+
+ @Override
+ public void
requestHeartbeat(ResourceID resourceID, Void payload) {
+
taskExecutorGateway.heartbeatFromJobManager(resourceID);
+ }
+ });
+
+ return new
JMTMRegistrationSuccess(JobMaster.this.resourceID,
libraryCacheManager.getBlobServerPort());
--- End diff --
`JobMaster.this.` not needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
