Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3385#discussion_r102993092
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/ZookeeperRegistry.java
 ---
    @@ -55,7 +59,7 @@ public void setJobRunning(JobID jobID) throws IOException 
{
                try {
                        String zkPath = runningJobPath + jobID.toString();
                        
this.client.newNamespaceAwareEnsurePath(zkPath).ensure(client.getZookeeperClient());
    -                   this.client.setData().forPath(zkPath);
    +                   this.client.setData().forPath(zkPath, 
RUNNING.getBytes());
    --- End diff --
    
    String to bytes conversion (and bytes to string) must always explicitly 
specify the encoding (Charset). Otherwise, there can be mismatches when 
different machines configure different default Charsets.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to