Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3365#discussion_r103433823
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/utils/BuilderUtils.java
---
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.runtime.webmonitor.utils;
+
+import org.apache.flink.api.common.ArchivedExecutionConfig;
+import org.apache.flink.api.common.ExecutionMode;
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.MeterView;
+import org.apache.flink.runtime.accumulators.StringifiedAccumulatorResult;
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.executiongraph.ArchivedExecution;
+import org.apache.flink.runtime.executiongraph.ArchivedExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ArchivedExecutionJobVertex;
+import org.apache.flink.runtime.executiongraph.ArchivedExecutionVertex;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.IOMetrics;
+import org.apache.flink.runtime.jobgraph.JobStatus;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.taskmanager.TaskManagerLocation;
+import org.apache.flink.runtime.util.EvictingBoundedList;
+import org.apache.flink.util.Preconditions;
+import org.apache.flink.util.SerializedValue;
+
+import java.net.InetAddress;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+public class BuilderUtils {
+ private static final Random RANDOM = new Random();
+
+ private BuilderUtils() {
+ }
+
+ public static ArchivedExecutionConfigBuilder
createArchivedExecutionConfig() {
+ return new ArchivedExecutionConfigBuilder();
+ }
+
+ public static class ArchivedExecutionConfigBuilder {
+ private String executionMode;
+ private String restartStrategyDescription;
+ private int parallelism;
+ private boolean objectReuseEnabled;
+ private Map<String, String> globalJobParameters;
+
+ private ArchivedExecutionConfigBuilder() {
+ }
+
+ public ArchivedExecutionConfigBuilder setExecutionMode(String
executionMode) {
+ this.executionMode = executionMode;
+ return this;
+ }
+
+ public ArchivedExecutionConfigBuilder
setRestartStrategyDescription(String restartStrategyDescription) {
+ this.restartStrategyDescription =
restartStrategyDescription;
+ return this;
+ }
+
+ public ArchivedExecutionConfigBuilder setParallelism(int
parallelism) {
+ this.parallelism = parallelism;
+ return this;
+ }
+
+ public ArchivedExecutionConfigBuilder
setObjectReuseEnabled(boolean objectReuseEnabled) {
+ this.objectReuseEnabled = objectReuseEnabled;
+ return this;
+ }
+
+ public ArchivedExecutionConfigBuilder
setGlobalJobParameters(Map<String, String> globalJobParameters) {
+ this.globalJobParameters = globalJobParameters;
+ return this;
+ }
+
+ public ArchivedExecutionConfig finish() {
--- End diff --
I think the canonical way to create the instance with a builder is to call
this `build()` (applies to the other builders as well).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
