[
https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888002#comment-15888002
]
ASF GitHub Bot commented on FLINK-5852:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3365#discussion_r103429562
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobVertexAccumulatorsHandler.java
---
@@ -36,20 +38,23 @@ public
JobVertexAccumulatorsHandler(ExecutionGraphHolder executionGraphHolder) {
@Override
public String handleRequest(AccessExecutionJobVertex jobVertex,
Map<String, String> params) throws Exception {
- StringifiedAccumulatorResult[] accs =
jobVertex.getAggregatedUserAccumulatorsStringified();
-
+ return createVertexAccumulatorsJson(jobVertex);
+ }
+ public static String
createVertexAccumulatorsJson(AccessExecutionJobVertex jobVertex) throws
IOException {
--- End diff --
Empty line missing before method
> Move JSON generation code into static methods
> ---------------------------------------------
>
> Key: FLINK-5852
> URL: https://issues.apache.org/jira/browse/FLINK-5852
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.3.0
>
>
> In order to implement the HistoryServer we need a way to generate the JSON
> responses independent of the REST API. As such i suggest to move the main
> parts of the generation code for job-specific handlers into static methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
