[
https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888049#comment-15888049
]
ASF GitHub Bot commented on FLINK-5870:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3376#discussion_r103455441
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -53,6 +59,11 @@ public TaskManagersHandler(FiniteDuration timeout,
MetricFetcher fetcher) {
}
@Override
+ public String[] getPaths() {
+ return new String[]{TASKMANAGERS_REST_PATH,
TASKMANAGER_DETAILS_REST_PATH};
--- End diff --
Just to double check: The handler is OK to handle both requests, right?
Before we created two instances of the handler. I think this is actually a case
where this works better than before.
> Make handlers aware of their REST URLs
> --------------------------------------
>
> Key: FLINK-5870
> URL: https://issues.apache.org/jira/browse/FLINK-5870
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.3.0
>
>
> The handlers in the WebRuntimeMonitor are currently unaware of the actual
> REST URL used. The handlers are simply registered under a given URL, without
> any guarantee that the handler can actually deal with that URL.
> I propose to let handlers themselves specify under which URL's they are
> supposed to be reachable. This provides are tighter coupling between URL and
> handler.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
