Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3365#discussion_r103463182
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java
---
@@ -54,6 +54,19 @@ public ArchivedExecutionConfig(ExecutionConfig ec) {
}
}
+ public ArchivedExecutionConfig(
+ String executionMode,
+ String restartStrategyDescription,
+ int parallelism,
+ boolean objectReuseEnabled,
+ Map<String, String> globalJobParameters) {
+ this.executionMode = executionMode;
--- End diff --
That would lead to maintainability issues. The ArchivedExecutionConfigs
very purpose is to truthfully represent some state X. In order to do so it must
only impose restrictions that the original object imposed, i.e the
ExecutionConfig, otherwise we risk that an ExecutionConfig can't be archived
which doesn't make sense. This in turn would require that any change to the
conditions that the EC imposes must be propagated to the ArchviedEC, which
simply won't happen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
