Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3365#discussion_r103502713
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java
 ---
    @@ -54,6 +54,19 @@ public ArchivedExecutionConfig(ExecutionConfig ec) {
                }
        }
     
    +   public ArchivedExecutionConfig(
    --- End diff --
    
    I wasn't mixing things up. For example, in ```Execution#archive()``` we 
create an ```ArchivedExecution``` through the use of the 
```ArchivedExecution(Execution)``` constructor. This pattern is identical for 
all Archived* classes except the EG (because we need some internal components 
and dont want to overload the class even more).
    
    Changing the constructor implies changing the ExecutionConfig, which imo is 
out of scope of this PR. Also, to be consistent, we would also have to touch 
other ```Archivable``` classes as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to