Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3423#discussion_r103476693
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetWindowAggregateMapFunction.scala
 ---
    @@ -34,13 +35,13 @@ import org.apache.flink.util.Preconditions
       * append an (aligned) rowtime field to the end of the output row.
       */
     class DataSetWindowAggregateMapFunction(
    --- End diff --
    
    We could remove this method if we rework the subsequent combine and 
groupReduce functions. This would allow use to use `accumulate` in `combine()` 
or non-combined `groupReduce()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to