Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103475581
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetTumbleCountWindowAggReduceGroupFunction.scala
---
@@ -63,27 +65,41 @@ class DataSetTumbleCountWindowAggReduceGroupFunction(
val iterator = records.iterator()
+ val accumulatorList = Array.fill(aggregates.length) {
+ new JArrayList[Accumulator]()
+ }
+
while (iterator.hasNext) {
val record = iterator.next()
+
if (count == 0) {
- // initiate intermediate aggregate value.
- aggregates.foreach(_.initiate(aggregateBuffer))
+ // clear the accumulator list for all aggregate
+ for (i <- aggregates.indices) {
+ accumulatorList(i).clear()
+ }
}
- // merge intermediate aggregate value to buffer.
- aggregates.foreach(_.merge(record, aggregateBuffer))
+ // collect the accumulators for each aggregate
+ for (i <- aggregates.indices) {
+ accumulatorList(i).add(record.getField(accumStartPos +
i).asInstanceOf[Accumulator])
--- End diff --
pairwise merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
