[ 
https://issues.apache.org/jira/browse/FLINK-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892111#comment-15892111
 ] 

ASF GitHub Bot commented on FLINK-5945:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3453
  
    @fhueske thanks for the review. The bug was affecting a test in `HITSTest` 
for which I have added the simple fix since I am improving the tests in 
FLINK-4896.
    
    Will merge after verification passes.


> Close function in OuterJoinOperatorBase#executeOnCollections
> ------------------------------------------------------------
>
>                 Key: FLINK-5945
>                 URL: https://issues.apache.org/jira/browse/FLINK-5945
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.1.4, 1.3.0, 1.2.1
>
>
> {{OuterJoinOperatorBase#executeOnCollections}} does not call 
> {{FunctionUtils.closeFunction(function);}}. I am seeing this affect the Gelly 
> test for the {{HITS}} algorithm when using a convergence threshold rather 
> than a fixed number of iterations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to