[ 
https://issues.apache.org/jira/browse/FLINK-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891034#comment-15891034
 ] 

ASF GitHub Bot commented on FLINK-5945:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3453

    [FLINK-5945] [core] Close function in 
OuterJoinOperatorBase#executeOnCollections

    Conclude OuterJoinOperatorBase#executeOnCollections with a call to 
FunctionUtils.closeFunction(function) in order to close rich user functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 
5945_close_function_in_OuterJoinOperatorBase#executeOnCollections

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3453
    
----
commit 933260bb35ac959880d2d22ffb1035f4c96590b4
Author: Greg Hogan <[email protected]>
Date:   2017-03-01T20:55:48Z

    [FLINK-5945] [core] Close function in 
OuterJoinOperatorBase#executeOnCollections
    
    Conclude OuterJoinOperatorBase#executeOnCollections with a call to
    FunctionUtils.closeFunction(function) in order to close rich user
    functions.

----


> Close function in OuterJoinOperatorBase#executeOnCollections
> ------------------------------------------------------------
>
>                 Key: FLINK-5945
>                 URL: https://issues.apache.org/jira/browse/FLINK-5945
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.1.4, 1.3.0, 1.2.1
>
>
> {{OuterJoinOperatorBase#executeOnCollections}} does not call 
> {{FunctionUtils.closeFunction(function);}}. I am seeing this affect the Gelly 
> test for the {{HITS}} algorithm when using a convergence threshold rather 
> than a fixed number of iterations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to