[
https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897468#comment-15897468
]
ASF GitHub Bot commented on FLINK-4714:
---------------------------------------
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3474
Hi @StephanEwen
I think this approach is cleaner than I do.
However, what I am concerned is that `setEnvironment()` method can be
inherited by `AbstractInvokable`'s subclass but constructor can't. It means all
subclasses need to implement this constructor and that is not enforced to do so.
Although we can update all subclasses with an one-argument constructor
which takes `env` only, I think it is not safer than setting `env` by calling a
final method.
What do you think? If there is any mistake in my words, please tell me as
well. Thank you.
> Set task state to RUNNING after state has been restored
> -------------------------------------------------------
>
> Key: FLINK-4714
> URL: https://issues.apache.org/jira/browse/FLINK-4714
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination, State Backends, Checkpointing
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Wei-Che Wei
>
> The task state is set to {{RUNNING}} as soon as the {{Task}} is executed.
> That, however, happens before the state of the {{StreamTask}} invokable has
> been restored. As a result, the {{CheckpointCoordinator}} starts to trigger
> checkpoints even though the {{StreamTask}} is not ready.
> In order to avoid aborting checkpoints and properly start it, we should
> switch the task state to {{RUNNING}} after the state has been restored.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
