[
https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897642#comment-15897642
]
ASF GitHub Bot commented on FLINK-4714:
---------------------------------------
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3474
Hi, @StephanEwen
I mean although all subclasses will be forced to call the one-argument
constructor, it doesn't force all subclasses need to have the one-argument
constructor. It seems not intuition to add an one-argument constructor if there
is another requirement for a new subclass.
However, tests might help us find out this mistake. Maybe it is not a
problem.
One more question, `StreamTask` needs `setInitialState()` to initialize
itself as well. Will that be okey to make the subclass of both
`AbstractInvokable` and `StatefulTask` to have two-arguments constructor and
remove `setInitialState()` method?
If it works fine for you and @tillrohrmann, I have no more question.
Please help me create a JIRA task for (1, 2). I will pend this PR until I
have finished that task and redo it as (3). Thank you.
> Set task state to RUNNING after state has been restored
> -------------------------------------------------------
>
> Key: FLINK-4714
> URL: https://issues.apache.org/jira/browse/FLINK-4714
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination, State Backends, Checkpointing
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Wei-Che Wei
>
> The task state is set to {{RUNNING}} as soon as the {{Task}} is executed.
> That, however, happens before the state of the {{StreamTask}} invokable has
> been restored. As a result, the {{CheckpointCoordinator}} starts to trigger
> checkpoints even though the {{StreamTask}} is not ready.
> In order to avoid aborting checkpoints and properly start it, we should
> switch the task state to {{RUNNING}} after the state has been restored.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
